Last Batch Policy changes for file source reader #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
swetha097
commented
Jul 17, 2024
•
swetha097
commented
- Modify the way sharding is handled
- Handle the various policies , pad_last_batch, stick_to_shard and shard_size.
- A new vector is introduced to store the file_names of the complete dataset instead of just the current shard data to support stick_to_shard.
- Pass the last batch policy and pad_last_batch_repeated to the loaders instead of the context creation.
- Introduce a struct ShardingInfo to hold variables related to sharding - last_batch_policy, pad_last_batch_repeated, stick_to_shard and shard_size.
… into swbs/lbp_fixes_pr10
|
@rrawther Resolved all the PR comments and tested with the Audio and Classification trainings. |
rrawther
reviewed
Sep 3, 2024
rrawther
reviewed
Sep 3, 2024
LakshmiKumar23
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.